Merge pull request #1595 from ydb-platform/fix-session-close-log

update session status only after logging it
ydb-platform · Dec 23, 2024 · ee17f9a · ee17f9a
2 parents e827ec1 + f3de353
commit ee17f9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Fixed an error in logging session deletion events
+
 ## v3.95.3
 * Supported of `database/sql/driver.Valuer` interfaces for params which passed to query using sql driver 
 * Exposed `credentials/credentials.OAuth2Config` OAuth2 config

diff --git a/internal/table/session.go b/internal/table/session.go
@@ -193,8 +193,8 @@ func (s *session) Close(ctx context.Context) (err error) {
 			s,
 		)
 		defer func() {
-			s.SetStatus(table.SessionClosed)
 			onDone(err)
+			s.SetStatus(table.SessionClosed)
 		}()
 
 		if time.Since(s.LastUsage()) < s.config.IdleThreshold() {