feat: use shiki for syntax highlight #3052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
Contributor
|
Skipped: This PR does not contain any of your configured keywords: ( |
Raubzeug
commented
Nov 7, 2025
| builtinFunctions, | ||
| keywords, | ||
| typeKeywords, | ||
| } from 'monaco-yql-languages/build/yql/yql.keywords'; |
Contributor
Author
There was a problem hiding this comment.
These constants are not valid yet, and it won't be undated in future. Soon it will be removed from the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to unify yql syntax highlight. For now it will use textmate grammar from monaco-yql-languages, which is generated by yql backend team.
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 66.08 MB | Main: 47.46 MB
Diff: +18.62 MB (39.23%)
ℹ️ CI Information