Skip to content

feat: use custom app title #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged

feat: use custom app title #2584

merged 3 commits into from
Jul 22, 2025

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Jul 18, 2025

closes ##2561

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 349 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.19 MB | Main: 85.18 MB
Diff: +3.55 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot July 21, 2025 07:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@astandrik astandrik requested a review from Copilot July 21, 2025 07:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@astandrik astandrik requested a review from Copilot July 21, 2025 07:35
Copilot

This comment was marked as outdated.

@astandrik astandrik requested a review from Copilot July 21, 2025 08:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements custom app title functionality by introducing a context-based system to replace the hardcoded "YDB Monitoring" title throughout the application. The changes allow users to configure a custom application title that will be displayed in browser tabs and page headers.

  • Introduces AppTitleContext for centralized title management
  • Updates all page components to use the custom app title instead of hardcoded "YDB Monitoring"
  • Refactors App component to support appTitle prop and remove Redux dependency for singleClusterMode

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/containers/App/AppTitleContext.tsx New context provider for managing custom app title
src/containers/App/App.tsx Refactored to support appTitle prop and use hooks instead of Redux connect
src/containers/App/Providers.tsx Updated to include AppTitleProvider in component tree
src/containers/AppWithClusters/AppWithClusters.tsx Added appTitle prop forwarding
src/containers/Cluster/Cluster.tsx Updated to use custom app title in Helmet
src/containers/Node/Node.tsx Updated to use custom app title in Helmet
src/containers/PDiskPage/PDiskPage.tsx Updated to use custom app title in Helmet
src/containers/StorageGroupPage/StorageGroupPage.tsx Updated to use custom app title in Helmet
src/containers/Tenant/Tenant.tsx Updated to use custom app title in Helmet
src/containers/VDiskPage/VDiskPage.tsx Updated to use custom app title in Helmet

@Raubzeug Raubzeug added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit c09d9be Jul 22, 2025
7 checks passed
@Raubzeug Raubzeug deleted the app-title branch July 22, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants