-
Notifications
You must be signed in to change notification settings - Fork 11
fix: update autorefresh if more that autorefresh in inactive tab passed #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use skipPollingIfUnfocused
in global rtk config!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/components/MetricChart/MetricChart.tsx:149
- [nitpick] The variable 'autorefresh' is used here instead of the common camelCase 'autoRefreshInterval' seen throughout the code. For consistency, consider renaming it.
{pollingInterval: autorefresh, skipPollingIfUnfocused: true}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed in pm, skipPollingIfUnfocused
works weird, so let's stick to your previous implementation
26e174b
to
c37dcba
Compare
@Raubzeug fixed, redeployed stand |
Closes #2123
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.36 MB | Main: 83.36 MB
Diff: +1.43 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information