Skip to content

fix: update autorefresh if more that autorefresh in inactive tab passed #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 11, 2025

Closes #2123

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 315 0 3 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.36 MB | Main: 83.36 MB
Diff: +1.43 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Contributor

@Raubzeug Raubzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use skipPollingIfUnfocused in global rtk config!

@astandrik astandrik requested review from Raubzeug and Copilot April 11, 2025 15:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/components/MetricChart/MetricChart.tsx:149

  • [nitpick] The variable 'autorefresh' is used here instead of the common camelCase 'autoRefreshInterval' seen throughout the code. For consistency, consider renaming it.
{pollingInterval: autorefresh, skipPollingIfUnfocused: true}

Copy link
Contributor

@Raubzeug Raubzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in pm, skipPollingIfUnfocused works weird, so let's stick to your previous implementation

@astandrik
Copy link
Collaborator Author

@Raubzeug fixed, redeployed stand

@astandrik astandrik requested a review from Raubzeug April 14, 2025 15:41
@astandrik astandrik added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit c5bd2ac Apr 15, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2123-2 branch April 15, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: update autorefresh if more that autorefresh in inactive tab passed
2 participants