GCC compile fix #339
Merged
GCC compile fix #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gazizonoki
reviewed
Nov 28, 2024
src/client/topic/impl/CMakeLists.txt
Outdated
| @@ -14,6 +14,8 @@ target_link_libraries(client-ydb_topic-impl PUBLIC | |||
| client-ydb_driver | |||
| client-ydb_topic-common | |||
| client-ydb_proto | |||
| client-ydb_topic | |||
There was a problem hiding this comment.
Здесь я не очень понял, зачем делать зависимость ydb_topic-impl от ydb_topic и ydb_topic-codecs?
There was a problem hiding this comment.
Упс, случайно попавший артефакт.
|
Если есть желание, было бы круто добавить запуск сборки и тестов под gcc в CI |
|
Не знаком с возможностями github по CI, постараюсь ознакомиться с ними и реализовать пожелание. |
|
Фикс полезный, но пока ресурсов не хватает, чтобы добавить новый прогон в CI. Так что пока замержим, но issue закрывать не будем: #328 |
Gazizonoki
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Успешность сборки проверял под Ubuntu-22.04 при помощи GCC-13 и clang-16.