Skip to content

[Blockstore] cells initial commit to main #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Blockstore] cells initial commit to main #3733

wants to merge 5 commits into from

Conversation

yegorskii
Copy link
Collaborator

@yegorskii yegorskii commented Jun 22, 2025 •
edited
Loading

#3783

Initial commit to support cell-based architecture in Blockstore. Implemented inter-cell transport using Grpc/Rdma and volume discovery in cells

@komarevtsev-d komarevtsev-d self-requested a review June 23, 2025 05:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 5f59a95.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8637 8626 0 4 5 2

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 5f59a95.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 117 0 1 0 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 5f59a95.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 42 0 1 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2e4a2f7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8637 8627 0 1 5 4

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 2e4a2f7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 112 0 0 0 0

komarevtsev-d
komarevtsev-d reviewed Jun 24, 2025
View reviewed changes
cloud/blockstore/config/sharding.proto
UNSET = 0;
GRPC = 1;
NBD = 2;
RDMA = 3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У нас принято называть значения с типом:

SHARD_DATA_TRANSPORT_UNSET
SHARD_DATA_TRANSPORT_GRPC
SHARD_DATA_TRANSPORT_NBD
SHARD_DATA_TRANSPORT_RDMA

@yegorskii yegorskii changed the title shards initial commit to main cells initial commit to main Jun 27, 2025
@yegorskii yegorskii added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Jun 27, 2025
@yegorskii yegorskii changed the title cells initial commit to main [Blockstore] cells initial commit to main Jun 27, 2025
@yegorskii yegorskii marked this pull request as ready for review June 27, 2025 09:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2e4a2f7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5005 5003 0 1 1 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2e4a2f7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5005 5003 0 1 1 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2e4a2f7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5005 5003 0 1 1 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komarevtsev-d komarevtsev-d komarevtsev-d left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yegorskii @komarevtsev-d