[Disk Manager] fix ydb binary path #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gy2411
added
large-tests
…yatest_common.binary_path
gy2411
force-pushed
the
users/gayurgin/fix_ydb_binary_path
branch
from
27ad5c8 to
b4b73ea
Compare
SvartMetal
approved these changes
Mar 7, 2025
jkuradobery
approved these changes
Mar 7, 2025
BarkovBG
reviewed
Mar 10, 2025
BarkovBG
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should handle exception when search for ydb binary path with yatest_common.binary_path.
This binary should not be found if we build without OPENSOURCE option https://github.com/ydb-platform/nbs/blob/main/cloud/disk_manager/test/snapshot_migration_test/ya.make#L62. The problem was the following: yatest_common.binary_path might throw exception instead of returning None.