Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3127: fixing log truncation #3136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue 3127: fixing log truncation #3136

wants to merge 1 commit into from
+1 −1

Conversation

Sazonov99
Copy link
Collaborator

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit bf2029b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6480 6469 0 1 8 2

@Sazonov99 Sazonov99 added the recheck Add this label to relaunch checks, it will be automatically removed label Mar 5, 2025
@github-actions github-actions bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 9d03841.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6478 6478 0 0 0 0

@Sazonov99 Sazonov99 marked this pull request as ready for review March 6, 2025 10:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1b9bdc0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6478 6478 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 651ec53.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6500 6499 0 1 0 0

@Sazonov99 Sazonov99 added the recheck Add this label to relaunch checks, it will be automatically removed label Mar 10, 2025
@github-actions github-actions bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 38db661.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6501 6501 0 0 0 0

debnatkh
debnatkh reviewed Mar 10, 2025
View reviewed changes
SvartMetal
SvartMetal reviewed Mar 10, 2025
View reviewed changes
cloud/filestore/libs/service/request.cpp
{
SetSingleLineMode(true);
SetExpandAny(true);
SetTruncateStringFieldLongerThan(64);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может просто поднимем эту константу в несколько раз?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Окей, давай сделаем так

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 1e23de3.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6493 6492 0 1 0 0

@Sazonov99 Sazonov99 closed this Mar 11, 2025
@Sazonov99 Sazonov99 force-pushed the users/sazonov/logs-trancating-fix branch from 1e23de3 to 277cf73 Compare March 11, 2025 04:15
@Sazonov99 Sazonov99 reopened this Mar 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit f62123c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6479 6469 0 0 8 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvartMetal SvartMetal SvartMetal approved these changes

@debnatkh debnatkh Awaiting requested review from debnatkh

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sazonov99 @SvartMetal @debnatkh