Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSI] Enable discard mount option only for YDB-based disks #3135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CSI] Enable discard mount option only for YDB-based disks #3135

wants to merge 2 commits into from
+85 −45

Conversation

antonmyagkov
Copy link
Collaborator

@antonmyagkov antonmyagkov commented Mar 4, 2025 •
edited
Loading

@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-enable-discard-only-for-ssd branch from ff5972b to 6ac5db5 Compare March 4, 2025 13:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6ac5db5.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6479 6479 0 0 0 0

@antonmyagkov antonmyagkov requested a review from SvartMetal March 10, 2025 15:39
@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-enable-discard-only-for-ssd branch from 6ac5db5 to 8699c9f Compare March 10, 2025 19:00
@antonmyagkov antonmyagkov changed the title [CSI] Enable discard mount option only for ssd [CSI] Enable discard mount option only for YDB-based disks Mar 10, 2025
@antonmyagkov antonmyagkov added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 8699c9f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3676 3676 0 0 0 0

SvartMetal
SvartMetal reviewed Mar 11, 2025
View reviewed changes
cloud/blockstore/tools/csi_driver/internal/driver/driver.go Outdated
@@ -67,6 +67,7 @@ type Config struct {
NfsLocalEndpointPort uint
NfsLocalEndpointSocket string
MountOptions string
Discard bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UseDiscardForYDBBasedDisks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

SvartMetal
SvartMetal reviewed Mar 11, 2025
View reviewed changes
cloud/blockstore/tools/csi_driver/internal/driver/node.go Outdated
@@ -124,6 +124,7 @@ type nodeService struct {
mounter mounter.Interface
volumeOps *sync.Map
mountOptions []string
discard bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useDiscardForYDBBasedDisks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6060fa6.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3676 3676 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvartMetal SvartMetal SvartMetal approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonmyagkov @SvartMetal