Fixed the use of the parameter ForcedCompactionRangeCountPerRun #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalibin
added
the
blockstore
SvartMetal
reviewed
Feb 25, 2025
SvartMetal
reviewed
Feb 25, 2025
cloud/blockstore/libs/storage/partition/part_actor_compactrange.cpp
Outdated
Show resolved
Hide resolved
SvartMetal
reviewed
Feb 25, 2025
cloud/blockstore/libs/storage/partition/part_actor_compactrange.cpp
Outdated
Show resolved
Hide resolved
agalibin
force-pushed
the
ForceCompactionFix
branch
from
6879746 to
e38fcbc
Compare
|
TEvVolume::TEvCompactRangeRequest может приходить с наружи (blockstore-client или pcompact-tablets) и содержит явное указание с какого блока и сколько компактить. Кажется что для такого сценария использовать ForcedCompactionRangeCountPerRun не стоит, поскольку внешний пользователь про этот параметр ничего не знает |
|
обсудили про обработку события снаружи, на будущее создал issue #3104 |
agalibin
added
the
recheck
github-actions
bot
removed
the
recheck
yegorskii
reviewed
Feb 26, 2025
yegorskii
reviewed
Feb 26, 2025
agalibin
force-pushed
the
ForceCompactionFix
branch
from
e38fcbc to
cd3a1ab
Compare
yegorskii
previously approved these changes
Feb 26, 2025
agalibin
added
the
recheck
github-actions
bot
removed
the
recheck
SvartMetal
reviewed
Feb 27, 2025
agalibin
force-pushed
the
ForceCompactionFix
branch
from
cd3a1ab to
00b06fe
Compare
SvartMetal
approved these changes
Feb 27, 2025
yegorskii
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of processed ranges for monitoring, as well as the index of the next range, were incremented by 1 instead of ForcedCompactionRangeCountPerRun. As a result, we were processing each range several times and displaying incorrect values in the monitoring.