issue-2404: don't start migration if it is already finished #2890
+581
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for contributing! |
komarevtsev-d
added
blockstore
github-actions
bot
removed
the
ok-to-test
cloud/blockstore/libs/storage/disk_registry/disk_registry_database.h
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
komarevtsev-d
requested changes
Jan 21, 2025
cloud/blockstore/libs/storage/disk_registry/disk_registry_database.h
Outdated
Show resolved
Hide resolved
| disk.FinishedMigrations, | ||
| [&](const auto& el) | ||
| { return el.DeviceId == deviceUUID && !el.IsCanceled; })); | ||
| } |
There was a problem hiding this comment.
В анонимный неймспейс можно утащить лучше, если никто не будет снаружи вызывать.
There was a problem hiding this comment.
тогда, чтобы объявить функцию, придется объявление TDiskRegistryState::TDiskState публичным делать, мне показалось, что лучше будет сделать статическую приватную функцию.
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
sharpeye
reviewed
Jan 21, 2025
cloud/blockstore/libs/storage/disk_registry/disk_registry_state_ut_migration.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state_ut_migration.cpp
Outdated
Show resolved
Hide resolved
vladstepanyuk
force-pushed
the
issue-2404
branch
from
2092be5 to
d67fc79
Compare
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
sharpeye
reviewed
Jan 22, 2025
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2404