Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2542: add message to stop DR based partition before volume destruction #2863

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Issue 2542: add message to stop DR based partition before volume destruction #2863

wants to merge 13 commits into from

Conversation

vladstepanyuk
Copy link
Contributor

@vladstepanyuk vladstepanyuk commented Jan 16, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@vladstepanyuk vladstepanyuk changed the title Issue 2542 Issue 2542: add message to stop DR based partition before volume destruction Jan 16, 2025
@komarevtsev-d komarevtsev-d added blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR ok-to-test Label to approve test launch for external members labels Jan 16, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 16, 2025
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 16, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit bd2171c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3766 3729 0 37 0 0

@komarevtsev-d komarevtsev-d self-requested a review January 16, 2025 11:06
komarevtsev-d
komarevtsev-d requested changes Jan 16, 2025
View reviewed changes
cloud/blockstore/libs/storage/volume/volume_actor_startstop.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/volume/volume_actor_startstop.cpp Outdated
LOG_ERROR(
ctx,
TBlockStoreComponents::VOLUME,
"[%lu] StopPartionBeforeVolumeDestruction req was send to not DR "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не стоит сокращать так сильно: req -> request.

Ну и лучше от отрицания избавиться, типа так:
"Only DR based volumes can handle StopPartionBeforeVolumeDestruction messages"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

сокращение поправил, но сообщение "Only DR based volumes can handle StopPartionBeforeVolumeDestruction messages" выглядит немного странно, в лог же надо писать что происходит, а не "такое сообщение не поддерживается"

cloud/blockstore/libs/storage/volume/volume_actor_startstop.cpp Outdated Show resolved Hide resolved
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 17, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit ce08484.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3766 3765 0 1 0 0

@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 20, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 11b0ec6.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3766 3765 0 1 0 0

komarevtsev-d
komarevtsev-d previously approved these changes Jan 20, 2025
View reviewed changes
sharpeye
sharpeye reviewed Jan 21, 2025
View reviewed changes
cloud/blockstore/libs/storage/api/volume.h Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/service/service_actor_destroy.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/volume/testlib/test_env.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/volume/volume_ut.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/protos/volume.proto Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/service/service_actor_destroy.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/service/service_actor_destroy.cpp Outdated
const TEvVolume::TEvStopPartitionBeforeVolumeDestructionResponse::TPtr& ev,
const TActorContext& ctx)
{
Y_UNUSED(ev);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ошибки проверять/ретраить запрос не надо?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавил обработку ошибки, в целом этот актор никак не ретраит/обрабатывает таймауты и undelivery, добавил один большой таймаут на весь актор

@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 22, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 22, 2025
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 22, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit d8aadda.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3778 3776 0 2 0 0

@komarevtsev-d
Copy link
Collaborator

Тесты кажется упали

@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 23, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 23, 2025
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 23, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 84ba6e1.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3787 3787 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharpeye sharpeye Awaiting requested review from sharpeye

@komarevtsev-d komarevtsev-d Awaiting requested review from komarevtsev-d

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladstepanyuk @komarevtsev-d @sharpeye