add fs and tablets counters #2756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkrorlqr
reviewed
Dec 23, 2024
| @@ -80,6 +80,8 @@ class TIndexTabletActor final | |||
| { | |||
| bool Initialized{false}; | |||
|
|
|||
| std::atomic<i64> FsCount{0}; | |||
There was a problem hiding this comment.
э, что еще за FsCount у конкретной таблетки? он же должен быть равен единице
не надо его тут
There was a problem hiding this comment.
Он не будет репортиться в метрики соответствующей фс. Так же как и следующий. будет только в аггрегированном виде в component=storage
There was a problem hiding this comment.
нет, выглядит странно
There was a problem hiding this comment.
Я не понимаю, зачем считать руками то что за меня могут посчитать автоматически в storage (придется пробрасывать в сервис информацию о том является ли таблетка шардом или нет и еще пересчитывать с учетом media kind). Зачем тащить в сервис то что ему совершенно не нужно?
qkrorlqr
reviewed
Dec 23, 2024
yegorskii
added
the
filestore
yegorskii
added
the
recheck
github-actions
bot
removed
the
recheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2829