add doc to setup trino+redis in docker #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glebbs
requested review from
vitalyisaev2,
dorooleg and
uzhastik
as code owners
uzhastik
reviewed
Jan 5, 2025
| └── readme.md | ||
| ``` | ||
|
|
||
| ## File Contents |
There was a problem hiding this comment.
Я бы предложил положить прямо файлики, а не описывать их имена и содержимое
There was a problem hiding this comment.
залил прям готовый сетап в папочку
vitalyisaev2
requested changes
Jan 9, 2025
| @@ -0,0 +1,19 @@ | |||
| version: '3.8' | |||
There was a problem hiding this comment.
Заведи, пожалуйста, папку "redis" по пути https://github.com/ydb-platform/fq-connector-go/tree/main/app/server/datasource/nosql и сложи всё эти файлы туда. Так мне будет легче найти, если что. И там будет всё твоё хозяйство.
Также, на будущее, понадобится добавить эти файлы частично или полностью в окружение для интеграционных тестов. Там docker-compose файл общий: https://github.com/ydb-platform/fq-connector-go/blob/main/tests/infra/datasource/docker-compose.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.