Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: reading from multiple databases concurrently #226

Merged
merged 15 commits into from
Dec 27, 2024

Validate port

6d51f30
Select commit
Loading
Failed to load commit list.
Merged

Logging: reading from multiple databases concurrently #226

Validate port
6d51f30
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 27, 2024 in 1s

63.29% (-0.24%) compared to 15f817b

View this Pull Request on Codecov

63.29% (-0.24%) compared to 15f817b

Details

Codecov Report

Attention: Patch coverage is 58.62745% with 211 lines in your changes missing coverage. Please review.

Project coverage is 63.29%. Comparing base (15f817b) to head (6d51f30).

Files with missing lines Patch % Lines
...ver/datasource/rdbms/logging/connection_manager.go 0.00% 54 Missing ⚠️
...erver/datasource/rdbms/logging/resolver_dynamic.go 0.00% 48 Missing ⚠️
...server/datasource/rdbms/logging/resolver_static.go 14.70% 29 Missing ⚠️
app/server/config/config.go 16.00% 16 Missing and 5 partials ⚠️
common/endpoint.go 0.00% 17 Missing ⚠️
app/server/datasource/s3/data_source.go 0.00% 11 Missing ⚠️
app/server/paging/sink_factory.go 91.86% 5 Missing and 2 partials ⚠️
app/server/datasource/rdbms/logging/resolver.go 37.50% 5 Missing ⚠️
app/server/paging/sink.go 50.00% 3 Missing and 2 partials ⚠️
app/server/paging/mock.go 50.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   63.52%   63.29%   -0.24%     
==========================================
  Files         116      116              
  Lines        8149     8391     +242     
==========================================
+ Hits         5177     5311     +134     
- Misses       2631     2737     +106     
- Partials      341      343       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov