Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDB: implement connection via Query Service #202

Merged
merged 21 commits into from
Oct 14, 2024
Merged

YDB: implement connection via Query Service #202

merged 21 commits into from
Oct 14, 2024

Conversation

vitalyisaev2
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 49.31507% with 222 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (4c48944) to head (1171186).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...p/server/datasource/rdbms/ydb/connection_native.go 0.00% 132 Missing ⚠️
app/server/datasource/rdbms/ydb/type_mapper.go 51.56% 31 Missing ⚠️
...server/datasource/rdbms/utils/predicate_builder.go 56.09% 18 Missing ⚠️
...er/datasource/rdbms/ydb/connection_database_sql.go 71.15% 9 Missing and 6 partials ⚠️
.../server/datasource/rdbms/ydb/connection_manager.go 53.84% 6 Missing ⚠️
...ver/datasource/rdbms/utils/query_args_collector.go 80.00% 4 Missing ⚠️
app/server/datasource/rdbms/ydb/sql_formatter.go 63.63% 4 Missing ⚠️
app/client/connector/client.go 0.00% 2 Missing ⚠️
app/server/config/config.go 77.77% 1 Missing and 1 partial ⚠️
app/server/datasource/rdbms/data_source.go 66.66% 1 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   64.80%   63.43%   -1.37%     
==========================================
  Files         104      107       +3     
  Lines        5750     5998     +248     
==========================================
+ Hits         3726     3805      +79     
- Misses       1710     1880     +170     
+ Partials      314      313       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.golangci.yml Outdated Show resolved Hide resolved
app/server/datasource/rdbms/ydb/connection_native.go Outdated Show resolved Hide resolved
app/server/datasource/rdbms/ydb/type_mapper.go Outdated Show resolved Hide resolved
@vitalyisaev2 vitalyisaev2 merged commit f76af43 into main Oct 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants