MySQL: sanitize identifiers

ydb-platform · Oct 3, 2024 · 8e1dc9d · 8e1dc9d
1 parent abb6b47
commit 8e1dc9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/server/datasource/rdbms/mysql/sql_formatter.go b/app/server/datasource/rdbms/mysql/sql_formatter.go
@@ -1,6 +1,9 @@
 package mysql
 
 import (
+	"fmt"
+	"strings"
+
 	"github.com/ydb-platform/ydb-go-genproto/protos/Ydb"
 
 	api_service_protos "github.com/ydb-platform/fq-connector-go/api/service/protos"
@@ -72,7 +75,7 @@ func (sqlFormatter) GetPlaceholder(_ int) string {
 }
 
 func (sqlFormatter) SanitiseIdentifier(ident string) string {
-	return ident
+	return fmt.Sprintf("`%s`", strings.Replace(ident, "`", "``", -1))
 }
 
 func (f sqlFormatter) FormatFrom(tableName string) string {

diff --git a/app/server/paging/mock.go b/app/server/paging/mock.go
@@ -36,7 +36,7 @@ type ColumnarBufferMock struct {
 	mock.Mock
 }
 
-//nolint:unused
+// nolint: unused
 func (*ColumnarBufferMock) addRow(_ RowTransformer[any]) error {
 	panic("not implemented") // TODO: Implement
 }