Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setuptools installed if missing for python >= 3.12 #1698

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CesarArroyo09
Copy link

Fixes #1618 adding setuptools as an optional requirement only if Python version is >= 3.12.

This was already being taken care off at #1619, but it seems this merge request was abandoned.

If there is a more appropriate way to do this, please share and I will implement it.

@ssiegel
Copy link

ssiegel commented Feb 3, 2025

The pkg_resources/setuptools issue may affect users on earlier python versions as well. When creating a venv with the --without-pip option and/or using uv for package management, the created venvs may be completely empty, without pip and setuptools, so the approach in this PR would not work. IMO #1619 is the correct approach: If we depend on something from setuptools (in this case pkg_resources), then it should simply be declared as a dependency.

@CesarArroyo09
Copy link
Author

I don't find any flaws in your approach.

Besides, if setuptools is already installed, then nothing would happen when setup as in #1619. I don't know why in the other PR it was suggested to add it as an optional dependency.

I just want it to be fixed any way or the other. It is very annoying when using Python 3.12 to figure out what is going on when just installing ydata-profiling and not being able to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'pkg_resources'
2 participants