Allow signing and verifying by hash #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows signing a message which isn't contiguous in memory, using normal (not prehashed) ed25519. A test for the new methods is added.
|
I've noticed a pull request for a similar feature in ed25519-dalek, though that API would only work for verification not signing (signing needs the hash twice whereas verification only needs one pass). dalek-cryptography/ed25519-dalek#196 |
|
Interesting choice of API, I like it! I was previously thinking of something along the lines of https://doc.rust-lang.org/std/io/trait.Read.html#method.read_vectored (to have precedent), that is, passing a slice of slices. There is movement in the Dalek repos, a long term goal would be to merge this library as a backend there so I no longer have to maintain it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need to sign and verify messages that are not contiguous in memory. These added methods allow that, with a user provided closure providing the hash of the message.
The use case is that I am serializing a message on-the-fly from parts to sign or verify, without copying it into a contiguous buffer. I have implemented
DynDigestso that the user provided functions can more easily use Salty's sha512.