Skip to content

added learn more page #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

JAYANTJOSHI001
Copy link
Contributor

Pull Request Template

Summary

added learn more page.
i am adding 3 ss having dark and light mode of current learn more page and a variation i thinked of,
and 2nd thing lmk where to connect this page (means where should i add this link '/learn-more' to move it to that page).

screencapture-localhost-3000-learn-more-2025-01-09-00_12_22
screencapture-localhost-3000-learn-more-2025-01-09-00_12_04

Variation(adding tabs)

screencapture-localhost-3000-learn-more-2025-01-09-00_01_16

Fixes #6

Type of Change

Please mark [X] for applicable items:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

Please describe the tests you performed to verify your changes:

Screenshots/Videos

Please attach relevant screenshots or videos demonstrating the changes.

Checklist

Please mark [X] for completed items:

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

updated navbar
added footer
added contact sectiom

Signed-off-by: JAYANTJOSHI001 <[email protected]>
Signed-off-by: JAYANTJOSHI001 <[email protected]>
new page for FAQ

Signed-off-by: JAYANTJOSHI001 <[email protected]>
Signed-off-by: JAYANTJOSHI001 <[email protected]>
Copy link

vercel bot commented Jan 8, 2025

@JAYANTJOSHI001 is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leetcode-journal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 6:17am

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks good. Thanks for your contributuion

Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the second version of tabs variations. create it as a component and export it to add in the main page.tsx Furthermore use card component of Shadcn and border effect of Magic UI

Kindly update and follow the guidelines to complete the changes.

@yashksaini-coder yashksaini-coder added good first issue Good for newcomers SWOC officially part of SWOC season 5 Beginner SWOC Level 1 issue Under Review The Pull Request is under Review Changes requested Changes are requested labels Jan 9, 2025
TabContainer component

Signed-off-by: JAYANTJOSHI001 <[email protected]>
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are good

@yashksaini-coder yashksaini-coder merged commit 70cb99d into yashksaini-coder:main Jan 9, 2025
3 checks passed
@yashksaini-coder yashksaini-coder added Points Assigned The points have been assigned on OS Lead and removed Under Review The Pull Request is under Review Changes requested Changes are requested labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner SWOC Level 1 issue good first issue Good for newcomers Points Assigned The points have been assigned on OS Lead SWOC officially part of SWOC season 5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Learn more page can be created
2 participants