Skip to content

Fixed problem with property selectedIndex="0". renderItem now works. Little fixes. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Artexoid wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed problem with property selectedIndex="0". renderItem now works. Little fixes. #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2b7b6
Fixed problem with property selectedIndex="0". Property renderItem no…
Artexoid Jul 10, 2018
9f78e33
Merge branch 'master' into master
Artexoid Dec 3, 2019
d7baf6f
Merge branch 'master' into master
Artexoid Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
View,
Text,
ScrollView,
Dimensions,
Platform,
} from 'react-native';
import PropTypes from 'prop-types';
Expand All @@ -17,6 +16,7 @@ const Container = styled.View`
width: ${props => props.wrapperWidth};
background-color: ${props => props.wrapperBackground};
`;

export const HighLightView = styled.View`
position: absolute;
top: ${props => (props.wrapperHeight - props.itemHeight) / 2};
Expand All @@ -27,28 +27,42 @@ export const HighLightView = styled.View`
border-top-width: ${props => props.highlightBorderWidth}px;
border-bottom-width: ${props => props.highlightBorderWidth}px;
`;

export const SelectedItem = styled.View`
height: 30px;
justify-content: center;
align-items: center;
height: ${props => props.itemHeight};
`;
const deviceWidth = Dimensions.get('window').width;

export const ItemText = styled.Text`
color: ${props => props.color};
font-size: 20px;
line-height: 26px;
text-align: center;
`;

export default class ScrollPicker extends React.Component {
constructor() {
super();
constructor(props) {
super(props);

this.onMomentumScrollBegin = this.onMomentumScrollBegin.bind(this);
this.onMomentumScrollEnd = this.onMomentumScrollEnd.bind(this);
this.onScrollBeginDrag = this.onScrollBeginDrag.bind(this);
this.onScrollEndDrag = this.onScrollEndDrag.bind(this);

this.renderItem = (this.props.renderItem || this.renderItemDefault).bind(this);

this.state = {
selectedIndex: 1,
}
}

componentDidMount() {
if (typeof this.props.selectedIndex !== 'undefined') {
this.scrollToIndex(this.props.selectedIndex);
if (this.props.selectedIndex !== undefined) {
setTimeout(() => {
this.scrollToIndex(this.props.selectedIndex);
}, 0);
}
}

Expand All @@ -59,7 +73,8 @@ export default class ScrollPicker extends React.Component {
}

render() {
const {header, footer} = this.renderPlaceHolder();
const { header, footer } = this.renderPlaceHolder();

return (
<Container wrapperHeight={this.props.wrapperHeight} wrapperWidth={this.props.wrapperWidth}
wrapperBackground={this.props.wrapperBackground}>
Expand All @@ -81,7 +96,7 @@ export default class ScrollPicker extends React.Component {
onScrollEndDrag={this.onScrollEndDrag}
>
{header}
{this.props.dataSource.map(this.renderItem.bind(this))}
{this.props.dataSource.map(this.renderItem)}
{footer}
</ScrollView>
</Container>
Expand All @@ -95,9 +110,10 @@ export default class ScrollPicker extends React.Component {
return {header, footer};
}

renderItem(data, index) {
renderItemDefault(data, index) {
const isSelected = index === this.state.selectedIndex;
const item = <Text style={isSelected ? this.props.activeItemTextStyle : this.props.itemTextStyle}>{data}</Text>;

const item = <ItemText color={isSelected === true ? this.props.activeItemColor : this.props.itemColor}>{data}</ItemText>;

return (
<SelectedItem key={index} itemHeight={this.props.itemHeight}>
Expand Down Expand Up @@ -197,6 +213,7 @@ export default class ScrollPicker extends React.Component {
}, 0);
}
}

ScrollPicker.propTypes = {
style: PropTypes.object,
dataSource: PropTypes.array,
Expand All @@ -215,13 +232,14 @@ ScrollPicker.propTypes = {
onMomentumScrollEnd: PropTypes.func,
onScrollEndDrag: PropTypes.func,
};

ScrollPicker.defaultProps = {
dataSource: [1, 2, 3],
itemHeight: 60,
wrapperBackground: '#FFFFFF',
wrapperHeight: 180,
wrapperWidth: 150,
highlightWidth: deviceWidth,
highlightWidth: '100%',
highlightBorderWidth: 2,
highlightColor: '#333',
onMomentumScrollEnd: () => {
Expand Down