Repository navigation
Label help overlay keys by what they do - #68
Merged
Merged
Conversation
|
Warning This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository. |
Ctrl+B r only toggles the preview panel, and Tab/Shift+Tab cycle panes, as the prefix map already says. Drop the two unused strings.
mgasner
force-pushed
the
fix/audio-disable-bitrate
branch
from
September 29, 2026 00:01
e7afe8d to
82908a4
Compare
mgasner
force-pushed
the
fix/help-overlay-labels
branch
from
September 29, 2026 00:01
3b9a755 to
0fd51c2
Compare
Coverage
|
yas open always serves the local server's UI, which lists configured remotes; a command-line target was silently dropped. Credentials in the echoed --on value are masked.
…from main.rs to lib.rs
ghost
approved these changes
Oct 10, 2026
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Ultimator's review of 24b7179
Relabels the help overlay entries (Tab → "Prev / Next pane", r → "Preview panel") and drops the now-unused i18n keys. It also carries the stacked #69 change, where yas open refuses --on and --hub instead of ignoring them. I found no issues in the diff, but I couldn't check out the repository, so I didn't grep for other uses of the removed i18n keys.
No issues found.
Reviewed in 19s · Session · @ultimator-agent review reviews again · @ultimator-agent fix fixes the open issues
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #67. Replaces #39, which was opened from indent-com/yas.
The help overlay now labels Ctrl+B r "Preview panel" and Tab "Prev / Next pane", which matches what those bindings do.
Tag
@indentto continue the conversation here.🤖 Generated with Claude Code