Repository navigation
Make surface capture and record flags match the server; allow negative scroll - #66
Merged
Merged
Conversation
|
Warning This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository. |
It only accepts https:// or loopback http:// URLs, never a directory.
yas clipboard set offers text/plain;charset=utf-8, but get asks for exactly text/plain by default, so set-then-get failed with NotFound. Get now resolves a plain-text request (text/plain with or without a charset, or UTF8_STRING) to whichever plain-text type the owner offered.
- capture --scale now resizes the surface with the RESIZE scale extension before capturing instead of being rejected. - capture --quality is removed: Surface CAPTURE has no quality input. - record --codec h264-444/av1-444 announce 4:4:4 through the view color capabilities extension instead of being rejected. - record help names the real default files (.h264, or .obu for AV1). - surface scroll accepts a negative amount, as learn.md shows.
mgasner
force-pushed
the
fix/clipboard-plain-text
branch
from
September 29, 2026 00:01
2c81944 to
56faf13
Compare
mgasner
force-pushed
the
fix/surface-capture-record-flags
branch
from
September 29, 2026 00:01
0379371 to
4f4945f
Compare
Coverage
|
yas clipboard set offers text/plain;charset=utf-8, but get asks for exactly text/plain by default, so set-then-get failed with NotFound. Get now resolves a plain-text request (text/plain with or without a charset, or UTF8_STRING) to whichever plain-text type the owner offered.
Base automatically changed from
fix/clipboard-plain-text
to
fix/ext-manage-from-help
September 29, 2026 17:12
…apture-record-flags; port capture quality removal from main.rs to lib.rs
ghost
approved these changes
Oct 10, 2026
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Ultimator's review of d06dee2
Wires capture --scale through the RESIZE scale extension, drops capture --quality, sends 4:4:4 color capabilities for record --codec h264-444 and av1-444, updates the help text, and lets surface scroll take negative amounts. I found nothing wrong in the diff. It has unit tests for the codec parsing, the scale extension and negative scroll parsing. I could not run the code: no checkout was available.
No issues found.
Reviewed in 12s · Session · @ultimator-agent review reviews again · @ultimator-agent fix fixes the open issues
Base automatically changed from
fix/ext-manage-from-help
to
fix/ext-run-output
October 10, 2026 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #64. Replaces #37, which was opened from indent-com/yas.
capture --scalenow resizes through the RESIZE scale extension instead of being rejected.capture --qualityis removed, because the server has no such input.record --codec h264-444andrecord --codec av1-444now announce 4:4:4.recordhelp now names the real default files.surface scrollaccepts negative amounts.Tag
@indentto continue the conversation here.🤖 Generated with Claude Code