Repository navigation
Describe ext manage --from as a registry URL - #62
Conversation
|
Warning This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository. |
It only accepts https:// or loopback http:// URLs, never a directory.
efdf9a0 to
756f440
Compare
a527d51 to
3cd5bc6
Compare
Coverage
|
yas clipboard set offers text/plain;charset=utf-8, but get asks for exactly text/plain by default, so set-then-get failed with NotFound. Get now resolves a plain-text request (text/plain with or without a charset, or UTF8_STRING) to whichever plain-text type the owner offered.
![ultimator-agent[bot]](https://avatars.githubusercontent.com/in/5124335?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ultimator's review of 84078cc
The --from help text now says it is a registry base URL (https://, or http:// on a loopback host). That matches Registry::fetch/validate_http_url, and README, learn.md and the design doc already call it a URL. The branch also carries #64's clipboard change, which the description doesn't mention: a plain-text get now uses resolve_mime to read whichever text/plain/UTF8_STRING variant the owner offered. That follows the compositor's own text aliasing in ExternalClipboard::data and sends the exact offered string that SelectionStore::get needs. I compiled resolve_mime and its test on their own and the test passes. I found no issues.
No issues found.
Session · @ultimator-agent review reviews again · @ultimator-agent fix fixes the open issues
There was a problem hiding this comment.
Ultimator's review of 79c95c5
79c95c5 merges the updated fix/ext-run-output base; the diff against that base retains the same registry-URL help correction and clipboard MIME resolution reviewed in round 1. I found no new issues in the PR-specific changes or their interaction with the base update. Tests were not rerun this round because sandbox commands timed out before execution.
No issues found.
Reviewed in 7m 12s · Session · @ultimator-agent review reviews again · @ultimator-agent fix fixes the open issues
2 participants
Stacked on #61. Replaces #35, which was opened from indent-com/yas.
The
--fromhelp text called it a directory, but it only acceptshttps://URLs (orhttp://on loopback). The help now calls it a registry URL.Tag
@indentto continue the conversation here.🤖 Generated with Claude Code