Skip to content

fix: pass SIGTERM to spawned yarn process (via yarnPath) #8543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: pass SIGTERM to spawned yarn process (via yarnPath) #8543

wants to merge 2 commits into from

Conversation

andreialecu
Copy link

@andreialecu andreialecu commented Jan 8, 2021 •
edited
Loading

Summary

SIGTERM would not be passed properly to yarn itself if yarnPath was being used

Originally reported at:

yarnpkg/berry#2347 (comment)

Test plan

Screenshot 2021-01-08 at 15 36 17

@andreialecu andreialecu mentioned this pull request Jan 8, 2021
Merged
3 tasks
@andreialecu
use unique index as key
12ec1d4 
`opts` is optional
@andreialecu andreialecu changed the title fix: SIGTERM not passed properly to spawned yarn process (via yarnPath) fix: pass SIGTERM to spawned yarn process (via yarnPath) Jan 12, 2021
@arcanis arcanis changed the base branch from master to 1.22-stable July 5, 2021 15:29
@arcanis arcanis changed the base branch from 1.22-stable to master July 5, 2021 15:30
@merceyz
Copy link
Member

merceyz commented Jul 26, 2021 •
edited
Loading

Thank you, merged as d64f979 and released in 1.22.11

@merceyz merceyz closed this Jul 26, 2021
@merceyz merceyz mentioned this pull request Oct 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreialecu @merceyz