Skip to content

Fix yarn "entrypoint" shell script #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2017
Merged

Fix yarn "entrypoint" shell script #3362

merged 1 commit into from
May 11, 2017

Conversation

pichouk
Copy link
Contributor

@pichouk pichouk commented May 10, 2017

Summary
#3260 PR broke the bin/yarn shell script (see issue #3321)
#3338 tried to fix it in a improper way

This way should work.

Test plan
I modify my /usr/bin/yarn file on my Debian (testing branch) and it fix the error message describe in #3321.
Could be great if someone test this on another platform, but it should be a generic solution.
To test this :

  • Install yarn 0.24.x
  • Modify your yarn bin script (location should depends on your distribution) as this PR does.
  • Run yarn -V. It should work without any error/warning messages from your shell.

#3260 PR broke the `bin/yarn` shell script (see issue #3321)
#3338 tried to fix it in a improper way

This way should work.
@bestander bestander merged commit 44ff2c3 into yarnpkg:master May 11, 2017
@bestander
Copy link
Member

Thank you ❤️

@pichouk pichouk deleted the patch-shell-script branch May 11, 2017 13:53
@Daniel15
Copy link
Member

We need to cherry-pick this into 0.24.x

Daniel15 pushed a commit that referenced this pull request May 12, 2017
#3260 PR broke the `bin/yarn` shell script (see issue #3321)
#3338 tried to fix it in a improper way

This way should work.
@Daniel15
Copy link
Member

Released in 0.24.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants