Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this is ready for review.
This builds on top of #439
recordSalt
callback (and tries to make it clearer what that callback should do).Using a key spec allows you to skip expensive key derivation which occurs every time you create a new DB connection.
Since we're generating random key data, as opposed to having the user specify a passphrase, there's no reason not to just generate a key-spec length key and skip derivation.
FWIW - We've been using this in production for about 9 months.