Merge pull request #4 from yaniv-golan/v0.4.0#5
Merged
Merged
Conversation
yaniv-golan
added a commit
that referenced
this pull request
Jun 4, 2026
…nner Follow-ups closing plan-vs-implementation gaps from the spec-sync work: - New deterministic integration test (test_ui_spec_sync.sh) asserting the gap #5 mimeType gating end-to-end: a client advertising a non-matching mimeTypes list gets _meta.ui stripped from tools, resources/list, and resources/read; a profile-advertising client gets it everywhere. - Wire test_ui_e2e.sh and test_ui_spec_sync.sh into test/integration/run.sh (previously the UI integration scripts were orphaned/un-run). - Document meta.preferredFrameSize (#11) in docs/concepts/mcp-apps.md. - Note the MCP Apps draft-delta status in SPEC-COMPLIANCE.md. - Refactor: single source of truth for the allowed permission keys (lib/validate.sh); shared result-builder for the two UI SDK helpers (sdk/ui-sdk.sh). No behavior change. list_changed (#3) end-to-end is left to deterministic unit coverage (ui_list_changed.bats incl. the poll path); a timing-based integration test proved flaky and is intentionally omitted. The legacy test_ui_resources.sh / test_ui_capability.sh remain un-wired: they have pre-existing harness bugs (sequential-block state/registry collision; a state-dir cleanup refusal) unrelated to this work. 682 unit tests pass; test/lint.sh clean; both wired UI integration tests green via the runner. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V0.4.0
Summary
Testing
./test/lint.sh./test/unit/run.sh./test/integration/run.sh(or targeted integration tests)Notes for Reviewers