V1.13.0 Feedback/Bug Fixes #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary field blocks from event, page, post, and profile entity view display configurations. - Removed field_audience and field_custom_vocab blocks. - Updated third_party_settings to reflect these changes.
|
Created multidev environment pr-877 for yalesites-platform. |
- Added new menu link for managing audience taxonomy - Added new menu link for managing custom vocabulary taxonomy
- Implemented ys_core_update_10002 to set default name for custom_vocab
This reverts commit ebb6e27. Turns out this isn't as easy as we thought. On sites without the vocab yet, this produces a chicken and egg problem.
Removed the shouldFeaturePinToTop method and its related getPinOptions method from ViewsBasicSort.php. The pin to top feature is no longer required, and the query now directly adds the order by sticky field.
|
@dblanken-yale taxonomy terms looks fixed 👍 |
Added a deploy hook function `ys_core_deploy_10001` to set the default taxonomy name for `custom_vocab` if it is NULL. This ensures that the taxonomy has a default name set during deployment.
- Implement CustomTaxonomyMenuLink class to extend MenuLinkDefault - Override getTitle method to fetch custom vocabulary name - Update ys_core.links.menu.yml to use CustomTaxonomyMenuLink class
Merged
|
im not sure if we are keeping this PR for more feedback to come, but im going to check all the changes up to this point
|
- Set 'Custom Vocab' name for custom_vocab taxonomy vocabulary - Update label for field_custom_vocab in event, page, post, and profile content types - Invalidate discovery cache after updates
The script no longer adds the yalesites-org/yalesites-reviewers as reviewers to the pull request. This change simplifies the PR creation process and allows for more flexible reviewer assignment.
This reverts commit 6c5f183.
feat: remove automatic reviewer assignment
miketullo95
approved these changes
Feb 13, 2025
dblanken-yale
added
pass code review
pass functional review
ready to merge
and removed
needs review
work in progress
labels
Even when there are none, we will still want to display the taxonomies chosen. We will instead opt to display a message should items not exist.
…nal form id for media library
Updated the denylisted blocks in various entity view display configurations to include 'wrapped_text_callout' and 'inline_block:wrapped_text_callout'. This change affects the event, page, post, and profile entity view displays. We will need to revert this for IYY.
…osed-filters YSP-678 Multiple views exposed filters on a page only work on last instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V1.13.0 Feedback/Bug Fixes
Description of work
field_audienceandfield_custom_vocabblocks from layout builder designcustom vocabname after creation/importAudienceandCustom Vocabmenu itemsVertical alignmentdown in Spotlight block formwrapped callout textfor now (reintroduce after first release)taxonomy displayfrom two column sectionsvideoandimage bannerdialsShow current noderespects its set value on view editFunctional testing steps: