YSP-592: AI: Content endpoint uses it's title for each node render #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When meta blocks render, they attempt to use the request object to get the title of the route. In the case of visiting a page, this works as intended, but in the case of our AI content endpoint, it resolves to that endpoint, resulting in the title always being 'Content Feed', since that is the title of that endpoint. This temporarily sets the route's title to the node's title so that the render can successfully occur using the correct title.
dblanken-yale
added
needs review
needs work
work in progress
and removed
work in progress
needs review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YSP-592: AI: Content endpoint uses it's title for each node render
When meta blocks render, they attempt to use the request object to get the title of the route. In the case of visiting a page, this works as intended, but in the case of our AI content endpoint, it resolves to that endpoint, resulting in the title always being 'Content Feed', since that is the title of that endpoint.
This temporarily sets the route's title to the node's title so that the render can successfully occur using the correct title.
Description of work
Functional testing steps: