fix: use DOMContentLoaded #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb33300
force-pushed
the
DOMContentLoaded
branch
from
7860cfd to
5a8b55e
Compare
Seb33300
force-pushed
the
DOMContentLoaded
branch
from
5a8b55e to
4643244
Compare
|
yajra
approved these changes
Apr 28, 2025
|
Released on https://github.com/yajra/laravel-datatables-html/releases/tag/v12.0.2 🚀 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project, we sometimes faces the following javascript error:
This is because buttons are defined inside the
DOMContentLoadedevent:https://github.com/yajra/laravel-datatables-vite/blob/3d1d1364e43f9bea547dae9a19236bcfd38d32bd/js/buttons/reset.js#L9
That error does not happens every time, I cannot explain why, but I am not able to reproduce it if I use
DOMContentLoadedinstead of$(function(){ }.For some reason, even if it is supposed to be equivalent to
DOMContentLoaded,$(function(){ }seems to be faster thanDOMContentLoadedin some cases.So let's use
DOMContentLoadedhere to be consistent with buttons.