Skip to content

Conversation

@amithad
Copy link
Member

@amithad amithad commented Sep 15, 2025

No description provided.

Signed-off-by: Amitha Dissanayake <[email protected]>
Copilot AI review requested due to automatic review settings September 15, 2025 10:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit tests for the core components of the ak-py library, replacing the minimal existing test. It introduces tests for session management, runtime configuration, configuration handling, and CLI testing utilities, while also updating the CI workflow to run both unit tests and end-to-end tests.

  • Adds unit tests for in-memory session store, runtime singleton pattern, and configuration loading
  • Introduces CLI testing utilities with fuzzy matching capabilities
  • Updates GitHub Actions workflow to include separate unit test job

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ak-py/tests/test_sessions_in_memory.py Tests for InMemorySessionStore operations including creation, loading, and clearing
ak-py/tests/test_runtime.py Tests for Runtime singleton pattern, agent registration, and session management
ak-py/tests/test_config.py Tests for configuration loading from YAML files and environment variable overrides
ak-py/tests/test_cli_tester.py Tests for CLI testing utilities with prompt handling and fuzzy matching
ak-py/tests/ak_core_test.py Removes placeholder test file
.github/workflows/test.yaml Updates workflow to add unit test job alongside existing CLI E2E tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@amithad amithad requested a review from hamparawa September 15, 2025 10:31
@amithad amithad requested a review from nuraj-yl September 15, 2025 11:04
@amithad amithad merged commit 672e166 into develop Sep 15, 2025
2 checks passed
@amithad amithad deleted the feature/unit_tests_for_ak_py branch September 15, 2025 11:05
@amithad amithad linked an issue Sep 15, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Framework (Unit Tests)

4 participants