fix: tracing import errors #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes import errors in tracing modules and adds Langfuse tracing support to the agent deployment. The import path corrections address a previous refactoring where framework implementations were moved from agentkernel.{framework} to agentkernel.framework.{framework} structure.
Key Changes
- Corrected import paths across all tracing modules (openllmetry and langfuse) to reference framework implementations from the
...framework.*namespace instead of the old direct namespace - Added Langfuse tracing integration to the agent deployment configuration, including required dependencies and environment variables
- Updated deployment scripts to reference correct relative paths after repository restructuring
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ak-py/src/agentkernel/trace/openllmetry/openai.py | Fixed import path from ...openai.openai to ...framework.openai.openai and reordered imports for consistency |
| ak-py/src/agentkernel/trace/openllmetry/langgraph.py | Fixed import path from ...langgraph.langgraph to ...framework.langgraph.langgraph and reordered imports |
| ak-py/src/agentkernel/trace/openllmetry/crewai.py | Fixed import path from ...crewai.crewai to ...framework.crewai.crewai and reordered imports |
| ak-py/src/agentkernel/trace/openllmetry/adk.py | Fixed import path from ...adk.adk to ...framework.adk.adk and reordered imports |
| ak-py/src/agentkernel/trace/langfuse/openai.py | Fixed import path from ...openai.openai to ...framework.openai.openai and reordered imports |
| ak-py/src/agentkernel/trace/langfuse/langgraph.py | Fixed import path from ...langgraph.langgraph to ...framework.langgraph.langgraph, reordered imports, and fixed indentation |
| ak-py/src/agentkernel/trace/langfuse/crewai.py | Fixed import path from ...crewai.crewai to ...framework.crewai.crewai and reordered imports |
| ak-py/src/agentkernel/trace/langfuse/adk.py | Fixed import path from ...adk.adk to ...framework.adk.adk and reordered imports |
| agent/pyproject.toml | Added langfuse extra to agentkernel dependency list |
| agent/deploy/variables.tf | Added Terraform variables for Langfuse configuration (secret key, public key, and base URL) |
| agent/deploy/main.tf | Added Langfuse environment variables to container configuration |
| agent/deploy/deploy.sh | Updated relative paths from ../../ak-py/dist to ../ak-py/dist and commented out build_index.sh call |
| agent/config.yaml | Added trace configuration enabling Langfuse tracing |
| agent/build.sh | Added langfuse extra to forced reinstall command for local development |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Amitha Dissanayake <[email protected]>
lakindu-yl
approved these changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uv pip install -r requirements.txt --target=dist/data --find-links ../../ak-py/dist | ||
| uv pip install --force-reinstall --target=dist/data --find-links ../../ak-py/dist agentkernel[api,openai,redis] || true | ||
| uv pip install -r requirements.txt --target=dist/data --find-links ../ak-py/dist | ||
| uv pip install --force-reinstall --target=dist/data --find-links ../ak-py/dist agentkernel[api,openai,redis] || true |
There was a problem hiding this comment.
The agentkernel installation in deploy.sh should include the 'langfuse' extra to match the dependency specification in pyproject.toml and build.sh. Currently, it only includes 'api,openai,redis' but should include 'api,openai,redis,langfuse' to ensure langfuse tracing dependencies are available during local deployment.
Suggested change
| uv pip install --force-reinstall --target=dist/data --find-links ../ak-py/dist agentkernel[api,openai,redis] || true | |
| uv pip install --force-reinstall --target=dist/data --find-links ../ak-py/dist agentkernel[api,openai,redis,langfuse] || true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.