Skip to content

Conversation

@manoj-bandara
Copy link
Contributor

Description

This allows passing images and files to Agents (google and openai agents) via REST API
It also contains a bug fix for a previous break in not handling the new run() signature in openlmmetry tracing

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update
  • CI/CD update
  • Other (please describe):

Related Issues

#121

Fixes #
Relates to #

Changes Made

REST API handler code
terraform state file change to support new end point
framework code for adk and openai
tracing runners to fix the previous break

Testing

  • [x ] Unit tests pass locally
  • Integration tests pass locally
  • Manual testing completed
  • New tests added for changes

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Copilot AI review requested due to automatic review settings December 11, 2025 01:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for passing images and files to agents via REST API, specifically for OpenAI SDK and Google ADK implementations. It also includes a bug fix for openllmetry tracing that was broken due to changes in the run() method signature.

Key changes:

  • Added multimodal input support (images and files) for OpenAI and Google ADK frameworks
  • Fixed tracing runners to use updated run() method signature with list[AgentRequest]
  • Added new /run-multipart endpoint for efficient file uploads
  • Enhanced REST API handler to process base64-encoded and multipart file data

Reviewed changes

Copilot reviewed 15 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ak-py/src/agentkernel/trace/openllmetry/*.py Fixed method signatures to accept list[AgentRequest] instead of prompt
ak-py/src/agentkernel/framework/openai/openai.py Added image and file handling with base64 and URL support
ak-py/src/agentkernel/framework/adk/adk.py Added multimodal support using Google ADK's Part types
ak-py/src/agentkernel/api/handler.py Added /run-multipart endpoint and file/image processing logic
docs/docs/api/rest-api.md Comprehensive documentation for image/file passing
examples/api/openai/app_test.py Added tests for image and file support with both JSON and multipart
examples/api/adk/ New ADK example with tests and configuration
ak-deployment/ak-aws/containerized/state.tf Added multipart endpoint to Terraform configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 18 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Copilot AI review requested due to automatic review settings December 11, 2025 09:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 18 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 11, 2025 12:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amithad amithad merged commit fe2b574 into develop Dec 11, 2025
10 of 11 checks passed
@amithad amithad deleted the feature/files_and_images branch December 11, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants