-
Notifications
You must be signed in to change notification settings - Fork 8
Feature/files and images support via REST API #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for passing images and files to agents via REST API, specifically for OpenAI SDK and Google ADK implementations. It also includes a bug fix for openllmetry tracing that was broken due to changes in the run() method signature.
Key changes:
- Added multimodal input support (images and files) for OpenAI and Google ADK frameworks
- Fixed tracing runners to use updated
run()method signature withlist[AgentRequest] - Added new
/run-multipartendpoint for efficient file uploads - Enhanced REST API handler to process base64-encoded and multipart file data
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ak-py/src/agentkernel/trace/openllmetry/*.py |
Fixed method signatures to accept list[AgentRequest] instead of prompt |
ak-py/src/agentkernel/framework/openai/openai.py |
Added image and file handling with base64 and URL support |
ak-py/src/agentkernel/framework/adk/adk.py |
Added multimodal support using Google ADK's Part types |
ak-py/src/agentkernel/api/handler.py |
Added /run-multipart endpoint and file/image processing logic |
docs/docs/api/rest-api.md |
Comprehensive documentation for image/file passing |
examples/api/openai/app_test.py |
Added tests for image and file support with both JSON and multipart |
examples/api/adk/ |
New ADK example with tests and configuration |
ak-deployment/ak-aws/containerized/state.tf |
Added multipart endpoint to Terraform configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 15 out of 18 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 15 out of 18 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Amitha Dissanayake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This allows passing images and files to Agents (google and openai agents) via REST API
It also contains a bug fix for a previous break in not handling the new run() signature in openlmmetry tracing
Type of Change
Related Issues
#121
Fixes #
Relates to #
Changes Made
REST API handler code
terraform state file change to support new end point
framework code for adk and openai
tracing runners to fix the previous break
Testing
Checklist