-
Notifications
You must be signed in to change notification settings - Fork 7
feat: tracing #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tracing #131
Conversation
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive tracing and observability capabilities to Agent Kernel through Langfuse integration. It introduces a new trace module with framework-specific instrumentation for OpenAI, LangGraph, CrewAI, and Google ADK, along with configuration options to enable/disable tracing.
Key Changes
- Added Langfuse tracing integration with OpenInference instrumentation for all supported frameworks
- Introduced new configuration schema for trace settings (enabled/disabled, provider type)
- Created comprehensive documentation for tracing setup, usage, and troubleshooting
Reviewed Changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
docs/docs/integrations/overview.md |
Added Observability & Monitoring section with Langfuse reference |
docs/docs/core-concepts/configuration.md |
Added trace configuration documentation with examples |
docs/docs/advanced/traceability.md |
Complete rewrite with Langfuse setup guide and usage instructions |
ak-py/uv.lock |
Added langfuse and openinference dependencies, downgraded wrapt |
ak-py/pyproject.toml |
Added langfuse extra with required instrumentation packages |
ak-py/src/agentkernel/trace/ |
New trace module with base classes and Langfuse implementation |
ak-py/src/agentkernel/core/config.py |
Added TraceConfig to configuration schema |
ak-py/src/agentkernel/openai/openai.py |
Integrated trace runner for OpenAI agents |
ak-py/src/agentkernel/langgraph/langgraph.py |
Integrated trace runner for LangGraph agents |
ak-py/src/agentkernel/crewai/crewai.py |
Integrated trace runner for CrewAI agents |
ak-py/src/agentkernel/adk/adk.py |
Refactored session management and integrated trace runner |
ak-py/tests/test_runtime.py |
Added trace configuration to test fixture |
ak-py/tests/test_module.py |
Updated DummyRunner signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
|
In the future we might have to go to a runner factory approach when are to support SSE as well. For now it's a simple if-else switch. |
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 23 out of 26 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Amitha Dissanayake <[email protected]>
Signed-off-by: Amitha Dissanayake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 25 out of 35 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tharindud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for now. We can tackle restructuring later.
No description provided.