feat: deprecate Runtime.instance() in favour of GlobalRuntime.instance() #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tharindu Dissanayake <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the Runtime.instance() method in favor of a new GlobalRuntime.instance() method, introducing better semantics for global runtime access. The deprecated package is added as a new dependency to manage the deprecation decorator.
- Introduces
GlobalRuntimeclass extendingRuntimeas the singleton runtime instance - Marks
Runtime.instance()as deprecated with version 0.2.4 - Updates all internal usages of
Runtime.instance()toGlobalRuntime.instance()
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ak-py/pyproject.toml | Adds deprecated>=1.3.1 as a new dependency |
| ak-py/uv.lock | Updates lock file with deprecated and wrapt package entries |
| ak-py/src/agentkernel/core/runtime.py | Adds deprecation decorator to Runtime.instance(), delegates to GlobalRuntime.instance() |
| ak-py/src/agentkernel/core/init.py | Exports GlobalRuntime alongside Runtime |
| ak-py/src/agentkernel/core/service.py | Updates to use GlobalRuntime.instance() instead of Runtime.instance() |
| ak-py/src/agentkernel/api/agent.py | Updates to use GlobalRuntime.instance() instead of Runtime.instance() |
| ak-py/src/agentkernel/api/rest_request_handler.py | Updates docstring example to use GlobalRuntime.instance() |
| ak-py/src/agentkernel/mcp/akmcp.py | Updates to use GlobalRuntime.instance() instead of Runtime.instance() |
| ak-py/src/agentkernel/a2a/a2a.py | Updates to use GlobalRuntime.instance() instead of Runtime.instance() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amithad
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tharindu Dissanayake [email protected]