Bugfix: Unsafe check on cursorword_id #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If ":call clearmatches()" was performed, it would break the cursorword highlighting for that window
Discovery
I discovered this bug while installing and testing out ThePrimeagen's latest harpoon update. When opening the harpoon menu, the clearmatches() function was called. This would cause an error message to pop up anytime the cursor moved in the popup menu. Closing the popup menu would fix it in the open file however.
I believe this is a bug in this plugin as there is a check on the existence of
cursorword_id
on thew
object, but that does not take into account whether that that id actually gets deleted.How to reproduce (discovery)
How to reproduce (general case)
Fix
Move deletion into a
pcall
function and retain previous code flow with theif
check.p.s. I am new to open source development. If there's anything i can fix about my post, please let me know. I would really appreciate it