-
Notifications
You must be signed in to change notification settings - Fork 7
build(cmake): Lower minimum Clang version for Velox compatibility: #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ce7241c
Remove traceableException feature and downgrade support of c++20 to c…
Bill-hbrhbr 1784467
Change compile definitions back to c++20
Bill-hbrhbr 292e6de
Setup and validate compiler versions
Bill-hbrhbr 5070e26
Transform all usages of std::ranges and std::views
Bill-hbrhbr fa39bd8
Update workflow to use llvm15 for macos-14
Bill-hbrhbr 59f3679
Address coderabbit review on cmake
Bill-hbrhbr f6df622
Address coderabbit comment on cpp
Bill-hbrhbr af310c9
Address coderabbit comments
Bill-hbrhbr 3d288e1
Update dev utils
Bill-hbrhbr 21680f6
Merge branch 'main' into velox-downgrade-cpp17
Bill-hbrhbr 75fb463
Remove llvm15 for macos14
Bill-hbrhbr ed0ea67
Apply suggestions from code review
Bill-hbrhbr 7f5e228
Remove unnecessary toolchain setup
Bill-hbrhbr 9ef42c1
Apply suggestions from code review
Bill-hbrhbr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # This file contains utility functions for validating toolchain versions to ensure compatibility | ||
| # with the C++20 features required by the project. | ||
|
|
||
| # Checks if the compiler ID and version meet the minimum requirements to support C++20 features | ||
| # required by the project. | ||
| function(validate_compiler_versions) | ||
| if("AppleClang" STREQUAL "${CMAKE_CXX_COMPILER_ID}") | ||
| set(CXX_COMPILER_MIN_VERSION "15") | ||
| elseif("Clang" STREQUAL "${CMAKE_CXX_COMPILER_ID}") | ||
| set(CXX_COMPILER_MIN_VERSION "15") | ||
| elseif("GNU" STREQUAL "${CMAKE_CXX_COMPILER_ID}") | ||
| set(CXX_COMPILER_MIN_VERSION "11") | ||
| else() | ||
| message( | ||
| FATAL_ERROR | ||
| "Unsupported compiler: ${CMAKE_CXX_COMPILER_ID}. Please use AppleClang, Clang, or GNU." | ||
| ) | ||
| endif() | ||
Bill-hbrhbr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if("${CMAKE_CXX_COMPILER_VERSION}" VERSION_LESS "${CXX_COMPILER_MIN_VERSION}") | ||
| message( | ||
| FATAL_ERROR | ||
| "${CMAKE_CXX_COMPILER_ID} version ${CMAKE_CXX_COMPILER_VERSION} is too low. Must be at" | ||
| " least ${CXX_COMPILER_MIN_VERSION}." | ||
| ) | ||
| endif() | ||
| endfunction() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 0 additions & 67 deletions
67
src/ystdlib/error_handling/test/test_TraceableException.cpp
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure md5sum is on PATH after installing coreutils on macOS
Homebrew’s coreutils installs md5sum under gnubin (not on PATH by default). If any step calls md5sum, it will fail unless you add gnubin to PATH or use gmd5sum explicitly.
Apply this diff to export gnubin to PATH robustly:
To verify whether md5sum (or gmd5sum) is actually used in the repo:
🏁 Script executed:
Length of output: 200
No md5sum usage detected – coreutils install step may be unnecessary
I searched the repo for any invocations of
md5sumorgmd5sumand found none. As a result:brew install coreutilsstep if it’s not actually used.md5sum:🤖 Prompt for AI Agents