Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update DFA to be templated on both a DFA state and NFA state. #87

Open
wants to merge 617 commits into
base: main
Choose a base branch
from

Conversation

SharafMohamed
Copy link
Contributor

@SharafMohamed SharafMohamed commented Feb 3, 2025

References

git fetch upstream pull/86/head:pr-86
git fetch upstream pull/87/head:pr-87
git diff pr-86 pr-87

Description

  • Instead of having member functions templated on the NFA state type, it makes more sense for the DFA itself to be templated on the NFA state type.

Validation performed

  • Existing tests pass.

Summary by CodeRabbit

  • Chores
    • Upgraded the build process to use a specified Ubuntu release and added conditional logging to provide better error feedback.
  • New Features
    • Introduced a unique identifier generator to enhance data management.
  • Refactor
    • Streamlined the pattern matching and capture handling components, improving state transitions and type safety.
  • Tests
    • Expanded test coverage to ensure robust performance of lexer and automata functionality.

SharafMohamed and others added 30 commits December 4, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant