Skip to content

feat(clp-s): Make lossless float retention the default behaviour for clp-s. #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2025
+7 −6
Merged

feat(clp-s): Make lossless float retention the default behaviour for clp-s. #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bb8d51
Make float format retention default in clp-s
gibber9809 Sep 23, 2025
1ea660a
Remove retain-float-format option in compression_task.py since it is …
gibber9809 Sep 23, 2025
a34b2a5
Merge branch 'main' into default-retain-float-format
gibber9809 Sep 23, 2025
9e2abd9
Merge branch 'main' into default-retain-float-format
gibber9809 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/core/src/clp_s/CommandLineArguments.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,9 @@ CommandLineArguments::parse_arguments(int argc, char const** argv) {
po::bool_switch(&m_print_archive_stats),
"Print statistics (json) about the archive after it's compressed."
)(
"retain-float-format",
po::bool_switch(&m_retain_float_format),
"Store extra information to losslessly decompress floats."
"no-retain-float-format",
po::bool_switch(&m_no_retain_float_format),
"Do not store extra information to losslessly decompress floats."
)(
"single-file-archive",
po::bool_switch(&m_single_file_archive),
Expand Down
6 changes: 4 additions & 2 deletions components/core/src/clp_s/CommandLineArguments.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ class CommandLineArguments {

OutputHandlerType get_output_handler_type() const { return m_output_handler_type; }

[[nodiscard]] bool get_retain_float_format() const { return m_retain_float_format; }
[[nodiscard]] auto get_retain_float_format() const -> bool {
return false == m_no_retain_float_format;
}

bool get_single_file_archive() const { return m_single_file_archive; }

Expand Down Expand Up @@ -181,7 +183,7 @@ class CommandLineArguments {
size_t m_target_encoded_size{8ULL * 1024 * 1024 * 1024}; // 8 GiB
bool m_print_archive_stats{false};
size_t m_max_document_size{512ULL * 1024 * 1024}; // 512 MB
bool m_retain_float_format{false};
bool m_no_retain_float_format{false};
bool m_single_file_archive{false};
bool m_structurize_arrays{false};
bool m_ordered_decompression{false};
Expand Down
1 change: 0 additions & 1 deletion components/job-orchestration/job_orchestration/executor/compress/compression_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ def _make_clp_s_command_and_env(
"--target-encoded-size",
str(clp_config.output.target_segment_size + clp_config.output.target_dictionaries_size),
"--compression-level", str(clp_config.output.compression_level),
"--retain-float-format",
]
# fmt: on

Expand Down
Loading