fix(nestjs-clerk): error handling

y-nk · Jan 19, 2025 · d5c0df0 · d5c0df0
1 parent 01429aa
commit d5c0df0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/nestjs-clerk/package.json b/nestjs-clerk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@y_nk/nestjs-clerk",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "auth and permission guards using clerk for nestjs",
   "homepage": "https://github.com/y-nk/nonorepo/tree/main/astro-components",
   "keywords": [

diff --git a/nestjs-clerk/src/auth.guard.ts b/nestjs-clerk/src/auth.guard.ts
@@ -2,6 +2,7 @@ import { clerkMiddleware, getAuth } from "@clerk/express";
 import {
   Inject,
   Injectable,
+  Logger,
   UnauthorizedException,
   type CanActivate,
   type ExecutionContext,
@@ -13,6 +14,8 @@ import type { ClerkConfig } from "./types";
 
 @Injectable()
 export class ClerkAuthGuard implements CanActivate {
+  private logger = new Logger(ClerkAuthGuard.name);
+
   constructor(
     private reflector: Reflector,
     @Inject(CLERK_CONFIG) private clerkConfig: ClerkConfig,
@@ -28,13 +31,19 @@ export class ClerkAuthGuard implements CanActivate {
     const res = context.switchToHttp().getResponse();
     const middleware = clerkMiddleware(this.clerkConfig);
 
-    const error = await new Promise<Error | undefined>((resolve) => {
+    const err = await new Promise<Error | undefined>((resolve) => {
       middleware(req, res, resolve);
     });
 
-    const auth = getAuth(req);
+    try {
+      if (err) throw err;
 
-    if (error || !auth.userId) throw new UnauthorizedException();
+      if (!getAuth(req)?.userId)
+        throw new Error("no auth data");
+    } catch (error) {
+      this.logger.error(error);
+      throw new UnauthorizedException();
+    }
 
     return true;
   }