Rename inklecate to inkjs-compiler #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smwhr
commented
May 7, 2022
| @@ -101,11 +104,11 @@ async function compileInkFile(inklecate) { | |||
| if (errors.length === 0) { | |||
| console.log("Done."); | |||
| } else { | |||
| errors.forEach((error) => console.error(`\n${error.reason.message}`)); | |||
| errors.forEach((error) => console.error(`\n${error.reason.message.substring(0,255)}`)); | |||
There was a problem hiding this comment.
When using the minified "inkjs-compiler.js", error message include the full unreadable stack trace. 255 chars should be enough to identify which test failed and run it individually.
smwhr
commented
May 7, 2022
| } | ||
| } | ||
|
|
||
| let inklecate = process.argv[3]; | ||
| let inklecate = process.argv[2]; |
There was a problem hiding this comment.
[2] was not used, not sure why it looked at [3]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The community has voted, so the renaming shall be !
Checklist
npm test).npm run-script lint).Description
Rename inklecate to inkjs-compiler
There was a small bug with
INCLUDEs when usinginkjs-compiler(path resolution was wrong), it's been updated.