update eslintrules + obvious mistakes

.eslintrc.js

@@ -26,17 +26,21 @@ module.exports = {
     "@typescript-eslint/no-namespace": "off",
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-unsafe-assignment": "off",
+    "@typescript-eslint/no-unsafe-argument": "off",
     "@typescript-eslint/no-unsafe-call": "off",
     "@typescript-eslint/no-unsafe-member-access": "off",
     "@typescript-eslint/no-unsafe-return": "off",
     "@typescript-eslint/restrict-plus-operands": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
     "@typescript-eslint/restrict-template-expressions": "off",
+    "@typescript-eslint/no-base-to-string": "off",
     "@typescript-eslint/ban-types": "off",
     "@typescript-eslint/unbound-method": "off",
     "@typescript-eslint/no-this-alias": "off",
     "@typescript-eslint/no-inferrable-types": "off",
     "@typescript-eslint/no-unnecessary-type-assertion": "off",
+    "@typescript-eslint/no-redundant-type-constituents": "off",
+    "@typescript-eslint/no-unsafe-enum-comparison": "off",
     "prefer-const": "off",
     "prefer-spread": "off",
     "prefer-rest-params": "off",

src/compiler/Parser/ParsedHierarchy/Divert/Divert.ts

@@ -449,7 +449,7 @@ export class Divert extends ParsedObject {
     const externalName: string | null = this.target
       ? this.target.firstComponent
       : null;
-    const external = context.externals.get(externalName as any);
+    const external = context.externals.get(externalName as string);
     if (!external) {
       throw new Error("external not found");
     }

src/compiler/Parser/ParsedHierarchy/Expression/Expression.ts

@@ -55,6 +55,7 @@ export abstract class Expression extends ParsedObject {
     return "Expression";
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   public Equals(obj: ParsedObject): boolean {
     return false;
   }

src/compiler/Parser/ParsedHierarchy/Flow/FlowBase.ts

@@ -138,6 +138,7 @@ export abstract class FlowBase extends ParsedObject implements INamedContent {
     return finalContent;
   };
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   public PreProcessTopLevelObjects(_: ParsedObject[]): void {
     // empty by default, used by Story to process included file references
   }

src/engine/ListDefinition.ts

@@ -56,8 +56,10 @@ export class ListDefinition {
     item = InkListItem.Null;
     return { result: item, exists: false };
   }
+
   public TryGetValueForItem(
     item: InkListItem,
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     /* out */ intVal: number
   ): TryGetResult<number> {
     if (!item.itemName) return { result: 0, exists: false };

src/engine/TypeAssertion.ts

@@ -63,6 +63,7 @@ export function isEquatable(type: any) {
 
 function unsafeTypeAssertion<T>(
   obj: any,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   type: (new () => T) | (Function & { prototype: T })
 ) {
   return obj as T;

src/tests/specs/setupTests.ts

@@ -2,6 +2,7 @@ export {};
 
 declare global {
   namespace jest {
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     interface Matchers<R> {
       toContainStringContaining(expected: string): CustomMatcherResult;
     }