Skip to content

Commit

Permalink
fix: ci
Browse files Browse the repository at this point in the history
  • Loading branch information
darkskygit committed Sep 12, 2024
1 parent e6a7f02 commit 8516718
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/y-octo-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: y-octo.${{ matrix.settings.target }}.node
path: ./y-octo-node/*.node
path: ./y-octo-node/dist
if-no-files-found: error

test-node:
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
uses: actions/download-artifact@v3
with:
name: y-octo.${{ matrix.settings.target }}.node
path: ./y-octo-node
path: ./y-octo-node/dist
- name: Run node binding tests
run: ls -lah & ls -lah tests
working-directory: y-octo-node
Expand Down
3 changes: 2 additions & 1 deletion y-octo-node/native/src/doc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ impl YDoc {
self.doc.apply_update_from_binary_v1(update)?;

// if update received from remote and current client state has been changed
// that means another client using same client id, we need to change the client id to avoid conflict
// that means another client using same client id, we need to change the client
// id to avoid conflict
if self.doc.get_state_vector().get(&client) != before_current_state {
self.doc.renew_client();
}
Expand Down
2 changes: 1 addition & 1 deletion y-octo-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"artifacts": "napi artifacts",
"build": "yarn build:binding && yarn build:js",
"build:debug": "yarn build:binding:debug && yarn build:js",
"build:js": "pkgroll",
"build:js": "pkgroll -- -",
"build:binding": "yarn build:binding:debug --release",
"build:binding:debug": "napi build --platform --no-const-enum --manifest-path native/Cargo.toml --dts ../src/yocto.d.ts --js ../src/yocto.js -o ./dist",
"universal": "napi universal",
Expand Down

0 comments on commit 8516718

Please sign in to comment.