Phase 0 — Stabilize architecture (remove self-HTTP, EF migrations, kill hash chip)#10
Merged
Conversation
Pre-existing uncommitted cockpit styling/nav tweaks present in the working tree before the overhaul branch. Committed as-is to preserve them; the cockpit is rebuilt cleanly in a later overhaul phase.
…d EF migrations Phase 0 of the Reve Intelligence overhaul (#1). - Remove DocumentApiClient; Home and Review call IDocumentWorkflow via DI instead of the component posting to its own Minimal API over HTTP. - Buffer each upload once and hand it to the workflow directly (no self re-POST). - Replace EnsureCreated with EF migrations (InitialCreate) + MigrateAsync; add a design-time DbContext factory and a local dotnet-ef tool manifest. - Add AsSplitQuery to the multi-collection document loads. - Pin System.Security.Cryptography.Xml 10.0.9 (EF Design pulled a vulnerable 9.0.0). - Remove the raw SHA-256 hash chip from the review header. DocumentEndpoints stays for the external API and export download URLs. Build 0 warnings; unit 2/2 and integration 5/5 green; format clean. Refs #1
This was referenced Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 of the Reve Intelligence overhaul. Closes #1.
What changed
HttpClientand POST to their own Minimal API.HomeandReviewnow callIDocumentWorkflowdirectly via DI. Uploads are buffered once and handed straight to the workflow.EnsureCreatedAsync()withMigrateAsync()+ anInitialCreatemigration; added a design-timeRevaDbContextFactoryand a localdotnet-eftool manifest under.config/.AsSplitQuery()on the multi-collection document loads (kills the EF single-query warning).System.Security.Cryptography.Xml10.0.9 (EF Design pulled a vulnerable 9.0.0 flagged by NuGetAudit).bf53…string). Hash stays in audit/export metadata only.DocumentEndpointsis kept for the external API and export download URLs (the UI no longer depends on it).Proof
dotnet build— 0 warnings, 0 errors.dotnet test— unit 2/2, integration 5/5 green.dotnet format --verify-no-changes— clean.Not in this phase (tracked separately)
Flat/fake confidence, classifier mislabel, real OCR/LLM, and the reference-grade UI land in #2–#7.