Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: remove .SILENT, make the targets loud #1309

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Flowdalic
Copy link
Contributor

@Flowdalic Flowdalic commented Dec 11, 2023

The Makefile was set globally to silent, which caused the failing commands to be not displayed. For example

flo@neo-pc xeps-xsf $ make html
make: *** [Makefile:112: build/xep-0001.html] Error 1

Removing this provides usefull information about which command failed:

flo@neo-pc xeps-xsf $ make html
xmllint --nonet --noout --noent --loaddtd --valid "xep-0001.xml" ! xmllint --nonet --noout --noent --loaddtd --xpath "//img/@src[not(starts-with(., 'data:'))]" xep-0001.xml 2>/dev/null && true make: *** [Makefile:110: build/xep-0001.html] Error 1

The Makefile was set globally to silent, which caused the failing
commands to be *not* displayed. For example

flo@neo-pc xeps-xsf $ make html
make: *** [Makefile:112: build/xep-0001.html] Error 1

Removing this provides usefull information about which command failed:

flo@neo-pc xeps-xsf $ make html
xmllint --nonet --noout --noent --loaddtd --valid "xep-0001.xml"
! xmllint --nonet --noout --noent --loaddtd --xpath "//img/@src[not(starts-with(., 'data:'))]" xep-0001.xml 2>/dev/null && true
make: *** [Makefile:110: build/xep-0001.html] Error 1
@deuill
Copy link
Contributor

deuill commented Jan 23, 2024

Seems that the underlying issue here is the same as encountered in #1316, were you able to solve these somehow @Flowdalic?

@Flowdalic Flowdalic merged commit caa1e57 into xsf:master Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants