Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0060: Release version 1.26.0 #1293

Merged
merged 1 commit into from
Mar 11, 2024
Merged

XEP-0060: Release version 1.26.0 #1293

merged 1 commit into from
Mar 11, 2024

Conversation

melvo
Copy link
Contributor

@melvo melvo commented Sep 7, 2023

Fix and add examples for publishing items:

  • Remove 'item' element specifying its ID from example response for publishing item with ID
  • Add examples for publishing item without ID

@Kev Kev added the Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. label Oct 30, 2023
@melvo
Copy link
Contributor Author

melvo commented Nov 25, 2023

@Kev Does this bug fix release really needs the council? If so, when will they decide on it?

@Kev
Copy link
Member

Kev commented Dec 11, 2023

By definition a bug fix is a substantive change, which means it needs Council, yes, sorry. Will poke again.

@iNPUTmice
Copy link
Contributor

Council has approved this PR under the condition that the change log gets changed to

Add examples for publishing item without ID

@Kev Kev added Needs Changes and removed Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. labels Dec 11, 2023
@melvo
Copy link
Contributor Author

melvo commented Dec 25, 2023

@Kev @iNPUTmice Thanks for the feedback. It should be ready to be merged now.

@Kev
Copy link
Member

Kev commented Jan 22, 2024

This isn't an editorial change, so it should advance x.Y.z instead of x.y.Z.

@melvo
Copy link
Contributor Author

melvo commented Jan 31, 2024

@Kev It is unclear to me why an example advances the minor version because it does not change any behavior. It would be good to have the versioning documented somewhere. Thus, I created #1200 and wrote to the mailing list but no one responded to it.

I pushed the version change for now.

Add examples for publishing item without ID
@melvo melvo changed the title XEP-0060: Release version 1.25.1 XEP-0060: Release version 1.26.0 Jan 31, 2024
@iNPUTmice iNPUTmice merged commit 9dfc1a9 into xsf:master Mar 11, 2024
1 check passed
@melvo melvo deleted the pubsub branch March 11, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants