feat: add erc20 features to v0.4.1 #4
Closed
GuillemGarciaDev wants to merge 197 commits intorelease/v0.4.xfrom
Closed
feat: add erc20 features to v0.4.1 #4GuillemGarciaDev wants to merge 197 commits intorelease/v0.4.xfrom
GuillemGarciaDev wants to merge 197 commits intorelease/v0.4.xfrom
Conversation
Fixed based on standard OZ convention: "the return value is optional (in rare cases), but if data is returned, it must not be false". Requiring the Transfer event to be emitted in these cases, since we can scan and check for that.
- remove estimation on internal calls - use max limit on internal calls - set refund quotient to 1 on internal calls - consume gas on CallEVMWithData - consume full gas on CallEVMWithData failures to match EVM standard
* add to invalid block params case * add test for filter error case * lint fix
* edit configs * lint-fix * fix * nl * to * to * cache * fix * fix * stupid * attempt fix flake test --------- Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
github-actions
bot
added
proto
types
build
CI
CLI
tests
contracts
precompile
release
labels
GuillemGarciaDev
changed the base branch from
release/v0.3.0-xrplevm
to
release/v0.4.x
AdriaCarrera
requested changes
Sep 10, 2025
AdriaCarrera
approved these changes
Sep 16, 2025
Collaborator
Author
There was a problem hiding this comment.
It does not exist, review last changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add erc20 features to v0.4.1
This PR enables
mint/burn/transfer-ownershipcapabilities to thev0.4.1cosmos/evm version. It merges the already applied erc20 changes fromrelease/v0.3.0-xrplevmbranch to thev0.4.1cosmos/evm tag.This PR MUST NOT be merged to release/v0.3.0-xrplevm. Only open to view changes
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md