Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: getIP #46

Merged
merged 1 commit into from
Jun 14, 2024
Merged

RF: getIP #46

merged 1 commit into from
Jun 14, 2024

Conversation

syywu
Copy link
Contributor

@syywu syywu commented Jun 13, 2024

@syywu syywu requested a review from Lissy93 as a code owner June 13, 2024 19:52
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 52.47% <25.92%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
checks/checks.go 0.00% <0.00%> (ø)
handlers/getIP.go 54.54% <50.00%> (+2.37%) ⬆️
server/server.go 0.00% <0.00%> (ø)
checks/getIP.go 26.08% <26.08%> (ø)

Lissy93
Lissy93 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Lissy93 Lissy93 merged commit dd5e713 into xray-web:main Jun 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syywu @Lissy93