Initial commit for Additional Theming Variables #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition is meant to add a layer of theming into Apollo without disrupting current Apollo implementation. Theme variables are meant to be updated at the base values (50-1000) and the semantically named colors will update automatically. This is also meant to work in conjunction with luminosity testing to identify colors for text on colors that provide sufficient contrast See a demo for the colors in use here: https://codepen.io/burnt-rocket/pen/bGvjJxW?editors=1100
…orward This could be a possible breaking change if there is someone out there using the other style of js variables
DanRader
commented
Sep 7, 2022
| @@ -65,7 +65,7 @@ | |||
| "files": [ | |||
| { | |||
| "destination": "colors.js", | |||
| "format": "javascript/umd", | |||
| "format": "javascript/es6", | |||
There was a problem hiding this comment.
This basically changes the output so that variables can be used more directly. The other format was causing problems because some of the names had hyphens and It didn't like it.
in UMD it looked like
background2: {
lm: _styleDitcionary.color.background-2.lm.value,
dm: color.background-2.dm.value
},
in ES6 it looks like
background2: {
lm: ColorBackground2Lm,
dm: ColorBackground2Dm
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is meant to add a layer of theming into Apollo without disrupting current Apollo implementation.
Theme variables are meant to be updated at the base values (50-1000) and the semantically named colors will update automatically.
This is also meant to work in conjunction with luminosity testing to identify colors for text on colors that provide sufficient contrast
See a demo for the colors in use here:
https://codepen.io/burnt-rocket/pen/bGvjJxW?editors=1100